CopyBot/Red-DiscordBot
1
0
Fork 0
mirror of https://github.com/Cog-Creators/Red-DiscordBot.git synced 2025-12-06 09:22:31 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make embeds in help output consistent (#5452)

Browse Source 
* Add `check_permissions` kwarg to `bot.embed_requested()`

* Make embeds in help consistent regardless of why it's being sent
This commit is contained in:
jack1142
2021-12-31 02:01:23 +01:00
committed by GitHub
parent faab711ec8
commit ff7c146b62
3 changed files with 27 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
redbot/core/commands/help.py
View File

@@ -358,7 +358,7 @@ class RedHelpFormatter(HelpFormatterABC):
grp = cast(commands.Group, command)
subcommands = await self.get_group_help_mapping(ctx, grp, help_settings=help_settings)
if await ctx.embed_requested():
if await self.embed_requested(ctx):
emb = {"embed": {"title": "", "description": ""}, "footer": {"text": ""}, "fields": []}
if description:
@@ -539,7 +539,7 @@ class RedHelpFormatter(HelpFormatterABC):
description = obj.format_help_for_context(ctx)
tagline = (help_settings.tagline) or self.get_default_tagline(ctx)
if await ctx.embed_requested():
if await self.embed_requested(ctx):
emb = {"embed": {"title": "", "description": ""}, "footer": {"text": ""}, "fields": []}
emb["footer"]["text"] = tagline
@@ -606,7 +606,7 @@ class RedHelpFormatter(HelpFormatterABC):
description = ctx.bot.description or ""
tagline = (help_settings.tagline) or self.get_default_tagline(ctx)
if await ctx.embed_requested():
if await self.embed_requested(ctx):
emb = {"embed": {"title": "", "description": ""}, "footer": {"text": ""}, "fields": []}
@@ -705,6 +705,11 @@ class RedHelpFormatter(HelpFormatterABC):
else:
yield obj
async def embed_requested(self, ctx: Context) -> bool:
return await ctx.bot.embed_requested(
channel=ctx.channel, user=ctx.author, command=red_help, check_permissions=True
)
async def command_not_found(self, ctx, help_for, help_settings: HelpSettings):
"""
Sends an error, fuzzy help, or stays quiet based on settings
@@ -717,7 +722,7 @@ class RedHelpFormatter(HelpFormatterABC):
),
min_score=75,
)
use_embeds = await ctx.embed_requested()
use_embeds = await self.embed_requested(ctx)
if fuzzy_commands:
ret = await format_fuzzy_results(ctx, fuzzy_commands, embed=use_embeds)
if use_embeds:
@@ -751,7 +756,7 @@ class RedHelpFormatter(HelpFormatterABC):
ret = _("Command *{command_name}* has no subcommand named *{not_found}*.").format(
command_name=command.qualified_name, not_found=not_found[0]
)
if await ctx.embed_requested():
if await self.embed_requested(ctx):
ret = discord.Embed(color=(await ctx.embed_color()), description=ret)
ret.set_author(
name=_("{ctx.me.display_name} Help Menu").format(ctx=ctx),