From 20682a543ae9a6f31f9a2b9d7ffe13bc9e92f911 Mon Sep 17 00:00:00 2001 From: Yiannis <1515939+styiannis@users.noreply.github.com> Date: Sat, 21 Mar 2026 16:38:30 +0200 Subject: [PATCH] chore: minor code enhancements --- .../static/js/utils/contexts/TextsContext.ts | 4 +- .../src/static/js/utils/settings/member.ts | 2 +- .../tests/utils/hooks/useBulkActions.test.tsx | 1 + frontend/tests/utils/hooks/useItem.test.tsx | 1 + .../tests/utils/hooks/useItemList.test.tsx | 8 +- .../hooks/useItemListInlineSlider.test.tsx | 24 ++-- .../utils/hooks/useItemListLazyLoad.test.tsx | 24 ++-- .../utils/hooks/useItemListSync.test.tsx | 14 +-- .../hooks/useManagementTableHeader.test.tsx | 1 + .../tests/utils/hooks/useMediaFilter.test.tsx | 1 + .../tests/utils/hooks/useMediaItem.test.tsx | 1 + frontend/tests/utils/hooks/usePopup.test.tsx | 4 +- frontend/tests/utils/hooks/useTheme.test.tsx | 1 - frontend/tests/utils/settings/api.test.ts | 106 +++++++++++------- frontend/tests/utils/settings/member.test.ts | 8 +- .../tests/utils/settings/optionsPages.test.ts | 10 +- .../tests/utils/settings/playlists.test.ts | 4 +- frontend/tests/utils/settings/theme.test.ts | 4 +- 18 files changed, 115 insertions(+), 103 deletions(-) diff --git a/frontend/src/static/js/utils/contexts/TextsContext.ts b/frontend/src/static/js/utils/contexts/TextsContext.ts index 986388b5..15d62767 100644 --- a/frontend/src/static/js/utils/contexts/TextsContext.ts +++ b/frontend/src/static/js/utils/contexts/TextsContext.ts @@ -3,9 +3,7 @@ import { config as mediacmsConfig } from '../settings/config'; const notifications = mediacmsConfig(window.MediaCMS).notifications.messages; -const texts = { - notifications, -}; +const texts = { notifications }; export const TextsContext = createContext(texts); diff --git a/frontend/src/static/js/utils/settings/member.ts b/frontend/src/static/js/utils/settings/member.ts index 3fed890e..a6797d28 100755 --- a/frontend/src/static/js/utils/settings/member.ts +++ b/frontend/src/static/js/utils/settings/member.ts @@ -78,7 +78,7 @@ export function memberConfig( } const mediaActions = features?.media?.actions; - if (mediaActions !== undefined) { + if (mediaActions) { ret.can.addComment = ret.can.addComment && mediaActions?.comment === true; ret.can.mentionComment = ret.can.mentionComment && mediaActions?.comment_mention === true; diff --git a/frontend/tests/utils/hooks/useBulkActions.test.tsx b/frontend/tests/utils/hooks/useBulkActions.test.tsx index 00fca6c5..1f16b9ff 100644 --- a/frontend/tests/utils/hooks/useBulkActions.test.tsx +++ b/frontend/tests/utils/hooks/useBulkActions.test.tsx @@ -1,5 +1,6 @@ import React from 'react'; import { render, fireEvent, act } from '@testing-library/react'; + import { useBulkActions } from '../../../src/static/js/utils/hooks/useBulkActions'; // Mock translateString to return the input for easier assertions diff --git a/frontend/tests/utils/hooks/useItem.test.tsx b/frontend/tests/utils/hooks/useItem.test.tsx index d75514b4..9931bd5b 100644 --- a/frontend/tests/utils/hooks/useItem.test.tsx +++ b/frontend/tests/utils/hooks/useItem.test.tsx @@ -1,5 +1,6 @@ import React from 'react'; import { render } from '@testing-library/react'; + import { useItem } from '../../../src/static/js/utils/hooks/useItem'; // Mock the item components diff --git a/frontend/tests/utils/hooks/useItemList.test.tsx b/frontend/tests/utils/hooks/useItemList.test.tsx index e895b962..a29453c0 100644 --- a/frontend/tests/utils/hooks/useItemList.test.tsx +++ b/frontend/tests/utils/hooks/useItemList.test.tsx @@ -1,6 +1,9 @@ import React, { createRef } from 'react'; import { render } from '@testing-library/react'; +import initItemsList from '../../../src/static/js/components/item-list/includes/itemLists/initItemsList'; +import { useItemList } from '../../../src/static/js/utils/hooks/useItemList'; + // Stub style imports used by the hook so Jest doesn't try to parse SCSS jest.mock('../../../src/static/js/components/item-list/ItemList.scss', () => ({}), { virtual: true }); @@ -9,9 +12,6 @@ jest.mock('../../../src/static/js/components/item-list/includes/itemLists/initIt default: jest.fn((_lists: any[]) => [{ appendItems: jest.fn() }]), })); -import initItemsList from '../../../src/static/js/components/item-list/includes/itemLists/initItemsList'; -import { useItemList } from '../../../src/static/js/utils/hooks/useItemList'; - function HookConsumer(props: any) { const listRef = createRef(); const [items, countedItems, listHandler, setListHandler, onItemsLoad, onItemsCount, addListItems] = useItemList( @@ -32,7 +32,7 @@ function HookConsumer(props: any) {