From 499196b0f623e022fcd335b173e939dc59d2d538 Mon Sep 17 00:00:00 2001
From: Yiannis <1515939+styiannis@users.noreply.github.com>
Date: Wed, 11 Mar 2026 02:31:07 +0200
Subject: [PATCH] chore(frontend): harden settings parsing and update store
 imports

---
 frontend/src/static/js/utils/settings/pages.ts       |  5 +++--
 frontend/src/static/js/utils/settings/taxonomies.ts  |  5 +++--
 frontend/src/static/js/utils/stores/PageStore.js     |  2 +-
 .../src/static/js/utils/stores/PlaylistPageStore.js  |  2 +-
 .../src/static/js/utils/stores/ProfilePageStore.js   |  2 +-
 .../src/static/js/utils/stores/SearchFieldStore.js   |  2 +-
 .../src/static/js/utils/stores/VideoViewerStore.js   |  2 +-
 frontend/src/static/js/utils/stores/index.ts         |  2 +-
 frontend/tests/utils/settings/pages.test.ts          | 12 ++++++++++++
 frontend/tests/utils/settings/taxonomies.test.ts     | 10 ++++++++++
 10 files changed, 34 insertions(+), 10 deletions(-)

diff --git a/frontend/src/static/js/utils/settings/pages.ts b/frontend/src/static/js/utils/settings/pages.ts
index 85bb3eea..49a685ca 100755
--- a/frontend/src/static/js/utils/settings/pages.ts
+++ b/frontend/src/static/js/utils/settings/pages.ts
@@ -21,8 +21,9 @@ export function pagesConfig(
 
         ret[key].enabled = settings[key]?.enabled === false ? false : true;
 
-        if (settings[key]?.title !== undefined) {
-            ret[key].title = settings[key].title.trim();
+        const title = settings[key]?.title;
+        if (typeof title === 'string') {
+            ret[key].title = title.trim();
         }
     }
 
diff --git a/frontend/src/static/js/utils/settings/taxonomies.ts b/frontend/src/static/js/utils/settings/taxonomies.ts
index be8332ca..5d66dc13 100755
--- a/frontend/src/static/js/utils/settings/taxonomies.ts
+++ b/frontend/src/static/js/utils/settings/taxonomies.ts
@@ -16,8 +16,9 @@ export function taxonomiesConfig(settings?: DeepPartial<GlobalMediaCMS['site']['
 
         ret[key].enabled = settings[key]?.enabled === false ? false : true; // @todo: Check this again
 
-        if (settings[key]?.title !== undefined) {
-            ret[key].title = settings[key].title.trim();
+        const title = settings[key]?.title;
+        if (typeof title === 'string') {
+            ret[key].title = title.trim();
         }
     }
 
diff --git a/frontend/src/static/js/utils/stores/PageStore.js b/frontend/src/static/js/utils/stores/PageStore.js
index ed8fc49d..0965c3bb 100644
--- a/frontend/src/static/js/utils/stores/PageStore.js
+++ b/frontend/src/static/js/utils/stores/PageStore.js
@@ -1,7 +1,7 @@
 import EventEmitter from 'events';
 import { BrowserCache } from '../classes/';
 import { BrowserEvents, exportStore } from '../helpers';
-import { config as mediaCmsConfig } from '../settings/config.js';
+import { config as mediaCmsConfig } from '../settings/config';
 
 function uniqid() {
   let a = new Uint32Array(3);
diff --git a/frontend/src/static/js/utils/stores/PlaylistPageStore.js b/frontend/src/static/js/utils/stores/PlaylistPageStore.js
index a706a753..a30c2292 100644
--- a/frontend/src/static/js/utils/stores/PlaylistPageStore.js
+++ b/frontend/src/static/js/utils/stores/PlaylistPageStore.js
@@ -2,7 +2,7 @@ import React from 'react';
 import EventEmitter from 'events';
 import { publishedOnDate, exportStore, getRequest, postRequest, deleteRequest, csrfToken } from '../helpers';
 
-import { config as mediacmsConfig } from '../settings/config.js';
+import { config as mediacmsConfig } from '../settings/config';
 
 const PlaylistPageStoreData = {};
 
diff --git a/frontend/src/static/js/utils/stores/ProfilePageStore.js b/frontend/src/static/js/utils/stores/ProfilePageStore.js
index 0d5bafa6..a54607d1 100755
--- a/frontend/src/static/js/utils/stores/ProfilePageStore.js
+++ b/frontend/src/static/js/utils/stores/ProfilePageStore.js
@@ -1,7 +1,7 @@
 import EventEmitter from 'events';
 import { exportStore, getRequest, deleteRequest, csrfToken } from '../helpers';
 
-import { config as mediacmsConfig } from '../settings/config.js';
+import { config as mediacmsConfig } from '../settings/config';
 
 class ProfilePageStore extends EventEmitter {
   constructor() {
diff --git a/frontend/src/static/js/utils/stores/SearchFieldStore.js b/frontend/src/static/js/utils/stores/SearchFieldStore.js
index f567436e..6ead2dc0 100755
--- a/frontend/src/static/js/utils/stores/SearchFieldStore.js
+++ b/frontend/src/static/js/utils/stores/SearchFieldStore.js
@@ -1,6 +1,6 @@
 import EventEmitter from 'events';
 import { exportStore, getRequest } from '../helpers';
-import { config as mediacmsConfig } from '../settings/config.js';
+import { config as mediacmsConfig } from '../settings/config';
 
 function getUrlVars() {
   var vars = {};
diff --git a/frontend/src/static/js/utils/stores/VideoViewerStore.js b/frontend/src/static/js/utils/stores/VideoViewerStore.js
index f1a5b99a..86933c7e 100755
--- a/frontend/src/static/js/utils/stores/VideoViewerStore.js
+++ b/frontend/src/static/js/utils/stores/VideoViewerStore.js
@@ -2,7 +2,7 @@ import EventEmitter from 'events';
 import { exportStore } from '../helpers/';
 import { BrowserCache } from '../classes/';
 
-import { config as mediacmsConfig } from '../settings/config.js';
+import { config as mediacmsConfig } from '../settings/config';
 
 let browserCache;
 
diff --git a/frontend/src/static/js/utils/stores/index.ts b/frontend/src/static/js/utils/stores/index.ts
index d38cd5c7..fd720386 100644
--- a/frontend/src/static/js/utils/stores/index.ts
+++ b/frontend/src/static/js/utils/stores/index.ts
@@ -14,4 +14,4 @@ export {
     ProfilePageStore,
     SearchFieldStore,
     VideoViewerStore,
-}
\ No newline at end of file
+};
diff --git a/frontend/tests/utils/settings/pages.test.ts b/frontend/tests/utils/settings/pages.test.ts
index 13d1ca4a..0d609dde 100644
--- a/frontend/tests/utils/settings/pages.test.ts
+++ b/frontend/tests/utils/settings/pages.test.ts
@@ -44,6 +44,18 @@ describe('utils/settings', () => {
             expect(cfg.recommended.title).toBe('Recommended');
         });
 
+        test('Ignores non-string titles and keeps defaults', () => {
+            const cfg = pagesConfig({
+                latest: { title: null as any },
+                featured: { title: 123 as any },
+                recommended: { title: true as any },
+            });
+
+            expect(cfg.latest.title).toBe('Recent uploads');
+            expect(cfg.featured.title).toBe('Featured');
+            expect(cfg.recommended.title).toBe('Recommended');
+        });
+
         test('Ignores unknown keys in settings', () => {
             const cfg = pagesConfig({
                 // @ts-ignore
diff --git a/frontend/tests/utils/settings/taxonomies.test.ts b/frontend/tests/utils/settings/taxonomies.test.ts
index 18f6d219..44995ac3 100644
--- a/frontend/tests/utils/settings/taxonomies.test.ts
+++ b/frontend/tests/utils/settings/taxonomies.test.ts
@@ -30,6 +30,16 @@ describe('utils/settings', () => {
             expect(res.tags).toStrictEqual({ enabled: true, title: 'My Tags' });
         });
 
+        test('Should ignore non-string title values and keep defaults', () => {
+            const res = taxonomiesConfig({
+                tags: { title: null as any },
+                categories: { title: 123 as any },
+            });
+
+            expect(res.tags).toStrictEqual({ enabled: true, title: 'Tags' });
+            expect(res.categories).toStrictEqual({ enabled: true, title: 'Categories' });
+        });
+
         test('Should ignore unknown taxonomy keys', () => {
             const input = {
                 unknownKey: { enabled: true, title: 'X' },